Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to toggle file paths in error messages #74

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

mm-david
Copy link
Contributor

Sometimes we want to be able to reduce the verbosity of logs, specifically, to not include file names in errors. This PR adds an optional configuration variable to toggle this behaviour (default: the current behaviour, which is to include file names). I've also taken the opportunity to move the growing list of options into their own struct to reduce the number of function arguments and allow for better documentation.

Copy link

github-actions bot commented Aug 13, 2024

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires an increase in your module’s major version number.
If the new major version number is 2 or greater,
you must also add or update the version suffix
on the module path defined in your go.mod file.
See the Go Modules Reference for more info.

no new version of package github.com/maxmind/mm-geofeed-verifier/v2/verify
  Major

@mm-david mm-david force-pushed the mm_david/hide-errors branch from bc71154 to ddb42af Compare August 13, 2024 21:22
@WhoIsSethDaniel
Copy link
Contributor

I assume you will perform the release following acceptance of this PR.

@mm-david
Copy link
Contributor Author

Yes, that's the plan.

@WhoIsSethDaniel WhoIsSethDaniel merged commit 1e68c42 into main Aug 14, 2024
18 checks passed
@WhoIsSethDaniel WhoIsSethDaniel deleted the mm_david/hide-errors branch August 14, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants