Remove mocket

[shadromani]

No description provided.

[shadromani]

The library seems to have a better way for querying the request data but it is not yet available in the latest release.

[oschwald]

This seems to be missing

[oschwald]

I think this should be updated similar to how the geoip2 one was updated.

[shadromani]

I wrote a comment before about why this is still using custom_handler. #148 (comment)
This specific test is checking the data of the request not the headers . I found this doc about how to do that RequestMatcherhttps://pytest-httpserver.readthedocs.io/en/latest/howto.html#querying-the-log
However the class used for doing this "RequestMatcher" is not available on the release 1.0.10 (which is the latest release I installed from pip) but from master.

[oschwald]

Ah, I am sorry, I didn't realize that comment was referring to this. Is there a reason why self.httpserver.expect_request(uri, method="POST", json=request)... doesn't work?

[shadromani]

I think it can work but we have to modify the assertion. How do you suggest to do that?

[oschwald]

I am not sure I fully understand. I would expect something like:

    def test_200_with_email_hashing(self):
        uri = "/".join(["/minfraud/v2.0", self.type])

        self.httpserver.expect_request(
            uri, 
            method="POST",
            json={
                "email": {
                    "address": "977577b140bfb7c516e4746204fbdb01",
                    "domain": "maxmind.com",
                }
            },
        ).respond_with_data(self.response)

        request = {"email": {"address": "[email protected]"}}
        self.run_client(getattr(self.client, self.type)(request, hash_email=True))

[shadromani]

This test has an assertion a few lines below. Can we remove if we go with what you suggested?

        self.assertEqual(
            {
                "email": {
                    "address": "977577b140bfb7c516e4746204fbdb01",
                    "domain": "maxmind.com",
                }
            },
            json.loads(httpretty.last_request.body),
        )
`

```

[oschwald]

Right, my suggested code moved that to the expected_request. If the request does not match that expectation, the server will return a 500 and the test will fail.

[oschwald]

We shouldn't be modifying many private attributes on the client class. I probably should have raised this on the geoip2 one, but there it was just one. Beyond modifying the internal state of the object in a confusing way, this bypasses any testing of the constructor.

I think it would be better to do something more similar to this and then passing the host and port through using the host paramter.

[shadromani]

how do you want the scheme (i.e. http or https) to be set for the client? pytest_httpserver runs on http, to run it as https we need another dependancy as described in this doc: https://pytest-httpserver.readthedocs.io/en/latest/howto.html#running-an-https-server

[oschwald]

See the link in my comment for how we set the scheme temporarily when there was an issue with mocket. I think we can just do that again. I don't think we want to make it part of the public API.

[oschwald]

Are we using this anywhere?