Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Build issues from using vcpkg port #354

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Fix Build issues from using vcpkg port #354

merged 1 commit into from
Aug 21, 2024

Conversation

ankurvdev
Copy link
Contributor

Using the maxminddb vcpkg port causes a unnecessary include to a private build "generated" folder that is found when using pre-built vcpkg libraries in another project

@ankurvdev
Fix Build issues from using vcpkg port
8d3f4f4 
Using the maxminddb vcpkg port causes a unnecessary include to a private build "generated" folder that is found when using pre-built vcpkg libraries in another project
oschwald
oschwald approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@oschwald oschwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oschwald oschwald merged commit ee4449b into maxmind:main Aug 21, 2024
15 checks passed
@ankurvdev
Copy link
Contributor Author

Thanks for merging.
For fixing the vcpkg port would it be possible to make a release anytime soon. So we can just move vcpkg to a newer release ?

@ankurvdev ankurvdev deleted the ankurvdev-patch-1 branch August 21, 2024 17:44
@oschwald
Copy link
Member

I released 1.11.0 with this change.

@dg0yt dg0yt mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oschwald oschwald oschwald approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankurvdev @oschwald