Merge pull request #41 from maxmind/greg/ignore-sync-errors

Ignore Sync() errors
maxmind · Sep 11, 2019 · 98bbeb0 · 98bbeb0
2 parents fa03a15 + 5d857cd
commit 98bbeb0
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/cmd/geoipupdate/main.go b/cmd/geoipupdate/main.go
@@ -12,7 +12,6 @@ import (
 	"net/url"
 	"os"
 	"path/filepath"
-	"runtime"
 	"strings"
 	"time"
 
@@ -423,11 +422,9 @@ func writeAndCheck(
 		}
 	}()
 
-	if runtime.GOOS != "windows" {
-		if err := dh.Sync(); err != nil {
-			return errors.Wrap(err, "error syncing database directory")
-		}
-	}
+	// We ignore Sync errors as they primarily happen on file systems that do
+	// not support sync.
+	_ = dh.Sync()
 
 	if verbose {
 		log.Printf("Updated %s", target)