metrocode is marked as deprecated in documentation #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying dev-site with
|
| Latest commit: |
4d76fe8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://71bdb825.dev-site-4ua.pages.dev |
| Branch Preview URL: | https://andram-metro-code-deprecatio.dev-site-4ua.pages.dev |
dlieou
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Looks good.
Just a couple of questions I have is do we want to update the examples by removing it from the examples such as the ones on geoip/docs/web-services/responses/?
I also see metro code mentioned in https://www.maxmind.com/en/geoip-databases
as well as https://support.maxmind.com/hc/en-us/articles/4414877149467-IP-Geolocation-Data.
|
thanks so much @dlieou the field is deprecated (I just updated the KB you linked to say so!) but we will continue to generate the data. Metro_code values will be out-of-date but still present in the databases, etc., hence no plan to remove it. |
dlieou
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.