Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center content #1205

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Center content #1205

merged 3 commits into from
Oct 9, 2024

Conversation

dhogan8
Copy link
Contributor

@dhogan8 dhogan8 commented Oct 9, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2024

Deploying dev-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: fe73b93
Status: ✅  Deploy successful!
Preview URL: https://cbe2c394.dev-site-4ua.pages.dev
Branch Preview URL: https://dallas-hugo-max-width.dev-site-4ua.pages.dev

View logs

Comment on lines +55 to +56
height: 2px;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before and after
Screenshot 2024-10-09 at 7 13 06 PM
Screenshot 2024-10-09 at 7 13 46 PM

Comment on lines +41 to +47
.home__sidebar {
display: none;

@media only screen and (min-width: 992px) {
display: none !important;
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is the best place for this styling, but given the home.scss file comes before the following, I wasn't sure where to put this:

.show {
  display: block !important
}

We could also forgo showing the sidebar completely on the homepage, but if we do that we should remove the button in the header in mobile.
Screenshot 2024-10-09 at 7 15 33 PM

@kevcenteno kevcenteno merged commit 8d4cc04 into hugo Oct 9, 2024
3 checks passed
@kevcenteno kevcenteno deleted the dallas/hugo-max-width branch October 9, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants