Skip to content

Commit

Permalink
Update workflow node version to v20
Browse files Browse the repository at this point in the history
  • Loading branch information
kevcenteno committed Oct 24, 2023
1 parent aad8763 commit 5927221
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 15 deletions.
13 changes: 8 additions & 5 deletions .github/workflows/production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- name: Get cached dependencies
id: cache-node-modules
Expand All @@ -65,6 +65,7 @@ jobs:
with:
path: |
functions/lib
functions/package.json
public
firebase.json
key: ${{ needs.cache-keys.outputs.build }}
Expand All @@ -87,7 +88,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- name: Get cached dependencies
uses: actions/cache@v3
Expand Down Expand Up @@ -117,13 +118,14 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- name: Get cached build
uses: actions/cache@v3
with:
path: |
functions/lib
functions/package.json
public
firebase.json
key: ${{ needs.cache-keys.outputs.build }}
Expand Down Expand Up @@ -153,13 +155,14 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- name: Get cached build
uses: actions/cache@v3
with:
path: |
functions/lib
functions/package.json
public
firebase.json
key: ${{ needs.cache-keys.outputs.build }}
Expand Down Expand Up @@ -198,7 +201,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- name: Get cached dependencies
uses: actions/cache@v3
Expand Down
15 changes: 9 additions & 6 deletions .github/workflows/staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- name: Get cached dependencies
uses: actions/cache@v3
Expand All @@ -61,6 +61,7 @@ jobs:
with:
path: |
functions/lib
functions/package.json
public
firebase.json
key: ${{ needs.cache-keys.outputs.build }}
Expand Down Expand Up @@ -89,7 +90,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- name: Get cached dependencies
uses: actions/cache@v3
Expand All @@ -113,7 +114,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- name: Get cached dependencies
uses: actions/cache@v3
Expand Down Expand Up @@ -142,13 +143,14 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- name: Get cached build
uses: actions/cache@v3
with:
path: |
functions/lib
functions/package.json
public
firebase.json
key: ${{ needs.cache-keys.outputs.build }}
Expand Down Expand Up @@ -198,13 +200,14 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- name: Get cached build
uses: actions/cache@v3
with:
path: |
functions/lib
functions/package.json
public
firebase.json
key: ${{ needs.cache-keys.outputs.build }}
Expand Down Expand Up @@ -239,7 +242,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- name: Get cached dependencies
uses: actions/cache@v3
Expand Down
2 changes: 1 addition & 1 deletion functions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"typescript": "^4.8.4"
},
"engines": {
"node": "18"
"node": ">=18"
},
"main": "lib/index.js",
"name": "functions",
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
"xml2js": "^0.5.0"
},
"engines": {
"node": ">=18",
"node": ">=20",
"npm": ">=9"
},
"license": "MIT",
Expand Down

0 comments on commit 5927221

Please sign in to comment.