-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pe/fix #36
Open
shamoons
wants to merge
11
commits into
maxjcohen:master
Choose a base branch
from
shamoons:pe/fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pe/fix #36
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6655445
Added a period parameter to the transformer (#1)
shamoons b74fa8d
Fix
shamoons 3e67b69
Fix
shamoons c62339f
Pe/fix (#2)
shamoons 820d4a9
Fixed
shamoons 7dd79b5
Pe/fix (#3)
shamoons 8df46b8
Edge check
shamoons 4ea6b11
Pe/fix (#4)
shamoons f896318
Pe/fix (#5)
shamoons c54af33
Fix
shamoons b236cc0
Merge branch 'master' into pe/fix
shamoons File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,9 +47,9 @@ class Transformer(nn.Module): | |
One of ``'chunk'``, ``'window'`` or ``None``. Default is ``'chunk'``. | ||
pe: | ||
Type of positional encoding to add. | ||
Must be one of ``'original'``, ``'regular'`` or ``None``. Default is ``None``. | ||
Must be one of `original, `regular` or `None. Default is `None`. | ||
pe_period: | ||
If using the ``'regular'` pe, then we can define the period. Default is ``24``. | ||
If using the ``regular`` pe, then we can define the period. Default is ``24``. | ||
""" | ||
|
||
def __init__(self, | ||
|
@@ -64,7 +64,7 @@ def __init__(self, | |
dropout: float = 0.3, | ||
chunk_mode: str = 'chunk', | ||
pe: str = None, | ||
pe_period: int = 24): | ||
pe_period: int = None): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I prefer having a default value here, of 24. |
||
"""Create transformer structure from Encoder and Decoder blocks.""" | ||
super().__init__() | ||
|
||
|
@@ -95,7 +95,9 @@ def __init__(self, | |
|
||
if pe in pe_functions.keys(): | ||
self._generate_PE = pe_functions[pe] | ||
self._pe_period = pe_period | ||
|
||
if pe == 'regular' and pe_period is not None: | ||
self._pe_period = pe_period | ||
Comment on lines
+98
to
+100
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems unnecessary, what edge case does it address ? |
||
elif pe is None: | ||
self._generate_PE = None | ||
else: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct syntax here should be:
``'original'``
for string values``24``
for number values``None``
for None