Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pe/fix #36

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tst/transformer.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ class Transformer(nn.Module):
One of ``'chunk'``, ``'window'`` or ``None``. Default is ``'chunk'``.
pe:
Type of positional encoding to add.
Must be one of ``'original'``, ``'regular'`` or ``None``. Default is ``None``.
Must be one of `original, `regular` or `None. Default is `None`.
pe_period:
If using the ``'regular'` pe, then we can define the period. Default is ``24``.
If using the ``regular`` pe, then we can define the period. Default is ``24``.
Comment on lines +50 to +52
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct syntax here should be:

  • ``'original'`` for string values
  • ``24`` for number values
  • ``None`` for None

"""

def __init__(self,
Expand All @@ -64,7 +64,7 @@ def __init__(self,
dropout: float = 0.3,
chunk_mode: str = 'chunk',
pe: str = None,
pe_period: int = 24):
pe_period: int = None):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer having a default value here, of 24.

"""Create transformer structure from Encoder and Decoder blocks."""
super().__init__()

Expand Down Expand Up @@ -95,7 +95,9 @@ def __init__(self,

if pe in pe_functions.keys():
self._generate_PE = pe_functions[pe]
self._pe_period = pe_period

if pe == 'regular' and pe_period is not None:
self._pe_period = pe_period
Comment on lines +98 to +100
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unnecessary, what edge case does it address ?

elif pe is None:
self._generate_PE = None
else:
Expand Down