Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sol::lib::jit to actually enable JIT ( resolves #899 ) #900

Merged
merged 4 commits into from
Oct 29, 2023

Conversation

WSSDude
Copy link
Collaborator

@WSSDude WSSDude commented Oct 29, 2023

Resolves #899 .

See comment #899 (comment)

@WSSDude
Copy link
Collaborator Author

WSSDude commented Oct 29, 2023

Just an additional note - I also try to run the test without LuaJIT in the first place, just LuaJIT about doubles the performance, but this makes it like 3x faster against just regular Lua package (Lua 5.4 version) for the linked test in the issue.

@maximegmd
Copy link
Owner

I think we should make this an option, given that we haven't used JIT for so long we may be running into some bugs, if we can give the option to disable it, people have options until the potential issues are resolved.

@WSSDude
Copy link
Collaborator Author

WSSDude commented Oct 29, 2023

Good point, I'll add some setting for it. Will we enable it by default?

@maximegmd
Copy link
Owner

I think we should enable it by default and explain that people can disable it if they encounter new errors

@WSSDude
Copy link
Collaborator Author

WSSDude commented Oct 29, 2023

Added it as an option, defaulted to true 👍

@WSSDude WSSDude merged commit 0544f6f into master Oct 29, 2023
2 checks passed
@WSSDude WSSDude deleted the feature/enable_jit branch October 29, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LuaJIT's JIT compiler is disabled by default
2 participants