Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix rsa ssh #457

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Attempt to fix rsa ssh #457

wants to merge 6 commits into from

Conversation

mxswd
Copy link
Contributor

@mxswd mxswd commented Mar 12, 2023

For whatever reason the signature I'm sending to OpenSSH doesn't validate and the connection gets rejected.

If you have any ideas let me know.

This is how I'm encoding the signature:
https://github.com/maxgoedjen/secretive/pull/457/files#diff-2aed467ebf696ae8d53d908364621e918247939acdb9e57463a9a91dd407710bR158

Which looks correct according to: https://www.ietf.org/rfc/rfc8332.txt

@mxswd mxswd marked this pull request as draft March 12, 2023 05:08
@@ -11,16 +11,19 @@ public class Updater: ObservableObject, UpdaterProtocol {
private let osVersion: SemVer
/// The current version of the app that is running.
private let currentVersion: SemVer
/// The current bundle prefix.
private let bundlePreifx: String

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is what appears to be a typo here, on line 26, and line 89. "bundlePreifx" -> "bundlePrefix"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants