Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taking a stab at setting api key via global config setup block #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spilliton
Copy link

I did not update the Readme yet as I'm not sure if this is how you would like it configured and whatnot...since this would change the method signatures of initializers and such it should prolly be a non-patch version bump I would think :)

@maxehmookau
Copy link
Owner

Seems pretty good, I like the approach! Add your name to the readme in the PR anyway and I'll review it in more detail in the coming week when I get a minute. Thank you very much!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0587a82 on spilliton:master into 9afe0bd on maxehmookau:master.

@spilliton
Copy link
Author

Sounds good thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants