WIP: [add] Process new_password_required #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parpa
changed the title
max-pv
reviewed
Jun 4, 2021
| @@ -70,5 +72,16 @@ func (a *App) Login(w http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| if res.ChallengeName != nil && *res.ChallengeName == "NEW_PASSWORD_REQUIRED" { | |||
There was a problem hiding this comment.
Let's have NEW_PASSWORD_REQUIRED defined as a constant similar to flowUsernamePassword and flowRefreshToken:
const challengeNamePasswordRequired = "NEW_PASSWORD_REQUIRED"
Comment on lines
+76
to
+82
| params = map[string]*string{ | ||
| "username": aws.String(username), | ||
| "session": res.Session, | ||
| } | ||
| b, _ := json.Marshal(params) | ||
| s := url.QueryEscape(string(b)) | ||
| http.Redirect(w, r, fmt.Sprintf("/new_password_required?params=%s", s), http.StatusFound) |
There was a problem hiding this comment.
That's a good idea, but I think the data object here is too simple to justify usage of encoding/json and net/url. Since go is about simplicity, could we do this instead?
Suggested change
| params = map[string]*string{ | |
| "username": aws.String(username), | |
| "session": res.Session, | |
| } | |
| b, _ := json.Marshal(params) | |
| s := url.QueryEscape(string(b)) | |
| http.Redirect(w, r, fmt.Sprintf("/new_password_required?params=%s", s), http.StatusFound) | |
| http.Redirect(w, r, fmt.Sprintf("/new_password_required?username=%s&session=%s", username, res.Session), http.StatusFound) |
| } | ||
| res, err := a.CognitoClient.RespondToAuthChallenge(chall) | ||
| if err != nil { | ||
| log.Println(err) |
There was a problem hiding this comment.
I don't think we need this log here :)
Comment on lines
+90
to
+101
| if (document.location.search.includes("params")) { | ||
| try { | ||
| const m = document.getElementById("params"); | ||
| m.style.display = "block"; | ||
| const params = document.location.search.replace("?params=", ""); | ||
| const str = decodeURIComponent(params); | ||
| const data = JSON.parse(str); | ||
| $("#username").val(data.username); | ||
| $("#session").val(data.session); | ||
| } catch (e) { | ||
| console.error(e); | ||
| } |
There was a problem hiding this comment.
Based on my comment above for login.go, this would simplify to just reading params from URL, and JSON.parse wouldn't be needed.
max-pv
reviewed
Jun 4, 2021
| params["SECRET_HASH"] = aws.String(secretHash) | ||
| } | ||
| chall := &cognito.RespondToAuthChallengeInput{ | ||
| ChallengeName: aws.String("NEW_PASSWORD_REQUIRED"), |
There was a problem hiding this comment.
Forgot one thing - this should be a constant IMO just like I mentioned here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handling of NEW_PASSWORD_REQUIRED event.
The account added from the cognito management background will be forced to change the password after logging in.