[add] env AWS_REGION #7
Conversation
parpa
commented
May 18, 2021
•
parpa
commented
- add env AWS_REGION
- add secret hash in register, close Secret hash is missing for register #5
- updae aws-sdk-go
- fix README.md
|
Hello This PR is related to #5 And fix AWS_REGION bug which COGNITO_USER_POOL_ID should be the same AWS_REGION. @br4in3x please let me know if it's ok with you or if I should change anything. Best wishes |
| ``` | ||
|
|
||
| With client secret: | ||
|
|
||
| ```go | ||
| AWS_PROFILE=XXX COGNITO_APP_CLIENT_ID=XXX COGNITO_APP_CLIENT_SECRET=XXX COGNITO_USER_POOL_ID=XXX PORT=8080 ./build/cognito | ||
| AWS_REGION=XXX COGNITO_APP_CLIENT_ID=XXX COGNITO_APP_CLIENT_SECRET=XXX COGNITO_USER_POOL_ID=XXX PORT=8080 ./build/cognito |
There was a problem hiding this comment.
I think we still need AWS_PROFILE along with AWS_REGION change. Sometimes there are more profiles than one default, so that's why it was here. Could you please explain why did you remove it?
There was a problem hiding this comment.
@br4in3x Thank you！
I use docker without setting the configuration file (~/.aws/credentials), we have already set COGNITO_APP_CLIENT_ID=XXX COGNITO_USER_POOL_ID=XXX only need to set another AWS_REGION to execute all APIs.
Because the Region is fixed in the main, I still can't debug successfully. I found that only AWS_REGION is required.
Is AWS_PROFILE necessary for your development environment?
There was a problem hiding this comment.
The purpose of this repo is to provide the simplest possible example of how to use Cognito in Go, therefore AWS_PROFILE is needed. I think that docker is a bit of an advance technique and might confuse other devs who just want to check out how this repo works. Because of this, I propose to have both AWS_PROFILE and AWS_REGION in the README, like this:
AWS_PROFILE=XXX AWS_REGION=XXX COGNITO_APP_CLIENT_ID=XXX COGNITO_APP_CLIENT_SECRET=XXX COGNITO_USER_POOL_ID=XXX PORT=8080 ./build/cognito
| @@ -28,6 +28,12 @@ func (a *App) Register(w http.ResponseWriter, r *http.Request) { | |||
| }, | |||
| } | |||
|
|
|||
| // Compute secret hash based on client secret. | |||
| if a.AppClientSecret != "" { | |||
There was a problem hiding this comment.
The a.AppClientSecret is not empty when we reach this if. Code inside this branch is not executed, you should just remove the if branch and the app will work perfectly.
