Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove tag onClick with custom ID if option externalTagId: true #213

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tagmanager.js
actionm committed May 3, 2014
commit 63af39a5d9c2d7b2e0aedd9d7b3ca91fd1bbcd84
4 changes: 4 additions & 0 deletions tagmanager.js
Original file line number Diff line number Diff line change
@@ -333,6 +333,10 @@
tlid.splice(idx, 1);
privateMethods.refreshHiddenTagList.call($self);
$self.trigger('tm:spliced', [tagBeingRemoved, tagId]);

if (tlis.length == 0) {
$self.trigger('tm:empty', null);
}
// console.log(tlis);
}