-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to bootstrap 5.3.2 #6
base: master
Are you sure you want to change the base?
Conversation
Thank you very much Ali! I will review the pull request soon :) |
Hi Ali and thanks for the pull request once again! Moving to more recent versions of bootstrap and potentially JQuery is needed. I understand that you probably had to do quite a lot of porting as things might have changed overtime. I did try the proposed changes and I noticed some changes that I would like to understand better:
Thanks! :) |
Hi Vasilios, Thank you so much for the feedback. I will check them and get back to you :) Regards |
Hi Vas, I've made some updates to the pull request, and I'd like to address your comments as follows: 1. Fonts: It appears that the font size has changed in the PR version, which is due to the upgrade to Bootstrap 5. To maintain consistency with the previous version, I've added a small CSS code to ensure the font size matches. 2. Popper CDN: I apologize for the misunderstanding. I mistakenly thought that Popper needed to be included, but it should only be included explicitly in specific cases. I've removed the line for including Popper from the CDN. 3. Top Menu Alignment: I couldn't identify any issues with the top menu alignment. To help me investigate further, could you please provide a screenshot of the problem and also try testing it on another browser? 4. JQuery to Popper Transition: According to the official website, jQuery is no longer required for certain functionalities. Bootstrap 5 now allows you to add toggleable hidden elements, modals, off-canvas menus, popovers, tooltips, and more without relying on jQuery. If you have any more questions or concerns, please feel free to ask. Your feedback is highly appreciated. Regards |
@mavroudisv have you given up on this project? |
I'll get back to you asap :) |
- Modified font color and family - Aligned navbar and figure
Hi @mavroudisv Thanks for the reply. No problem.
Regards, |
Is this upgrade going to be merged with the main branch, or is that no longer needed? |
@alimohebbi thanks for the edits and apologies for the delay. I'm keen to merge your PR. I'm still facing issues with alignment though. This happens if I resize the page (in width). The current version is robust to this, so there must be a way. @maitra yes, we are ironing out some details and hope to merge soon. |
Hi Vasilios,
Thank you for creating this valuable repository. I've upgraded it to use Bootstrap 5.3.2 while maintaining the original style. The changes include:
I believe this update will benefit more researchers looking to use this template with the latest Bootstrap features. Please consider accepting this pull request.
Best regards,
Ali