Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NTRIP support to feed RCTM data #12078

Open
wants to merge 6 commits into
base: Stable_V4.4
Choose a base branch
from

Conversation

zdanek
Copy link
Collaborator

@zdanek zdanek commented Nov 8, 2024

Adds support for NTRIP source for RTCM data.

Description

Work based on code of @TobinHall and @WTPENGUIN

Test Steps

Run the app. Enter NTRIP server details in settings. Connect to the vehicle, observe GPS received reporting status 6 - RTK Fixed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zdanek zdanek changed the title Add NTRIP support to feed Add NTRIP support to feed RCTM data Nov 8, 2024
@HTRamsey
Copy link
Collaborator

I guess this replaces #9493?

@zdanek
Copy link
Collaborator Author

zdanek commented Nov 11, 2024

Yes, it enhances that code.

@zdanek
Copy link
Collaborator Author

zdanek commented Nov 11, 2024

Build fails are because I've added some rtcm code into GPS drivers, that are hosted on px4 repo. I don't know how to handle such case. I don't want to influence px4 code, but I sure about my changes.

@SkycutterUAS
Copy link

SkycutterUAS commented Nov 21, 2024

Hopefully this can be resolved and merged soon - we are very supportive of this!

@zdanek
Copy link
Collaborator Author

zdanek commented Nov 22, 2024 via email

@zdanek zdanek force-pushed the v442_rtk_ntrip_vrs branch from 68fbe6e to 5848c0a Compare December 4, 2024 16:47
@SkycutterUAS
Copy link

Hi Bartek, how is the testing of NTRIP support?

@zdanek zdanek force-pushed the v442_rtk_ntrip_vrs branch from 5848c0a to 67afe00 Compare December 17, 2024 12:35
@HTRamsey
Copy link
Collaborator

@zdanek Do you have any plans to port this to master afterwards? If not I'd be happy to do it if you don't mind. Multiple people have been asking for this

@zdanek
Copy link
Collaborator Author

zdanek commented Dec 24, 2024

@HTRamsey yes, I do. Last days were very intense in regards testing this feature. Imagine, it works even on a tablet with Android. Not only a PC.

The only thing I a support with is a PR to px4 repo because I have a fix to RTCM parsing code

zdanek/PX4-GPSDrivers@47fdaa6

Currently we have a git submodule pointing to px4 repo. I'm not sure if they will accept my fix.

Last question, @HTRamsey so shall then prepare another version for master, that is based on QT6, right?

@HTRamsey
Copy link
Collaborator

Perfect, thanks. @julianoes could probably help with the PX4 GPS PR. And yes it is Qt6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants