Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTM: Refactor Network Remote ID telemetry control based on vehicle state #12073

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

royzah
Copy link

@royzah royzah commented Nov 7, 2024

Description

This PR refactors the UTMSPServiceController::networkRemoteID method to improve telemetry control logic:

  • Removes position-based telemetry control logic
  • Adds state-based control using MAV_STATE from HEARTBEAT messages
  • Telemetry now starts when vehicle is in MAV_STATE_ACTIVE state
  • Telemetry stops when vehicle transitions out of MAV_STATE_ACTIVE state
  • Simplifies code flow and removes unnecessary position comparisons

Test Steps

  1. Connect vehicle to QGC
  2. Setup UTM Network Remote ID parameters (serialNumber, operatorID, flightID)
  3. Verify telemetry starts when vehicle enters MAV_STATE_ACTIVE
  4. Verify telemetry continues at 3Hz while in MAV_STATE_ACTIVE
  5. Verify telemetry stops when vehicle exits MAV_STATE_ACTIVE state
  6. Check logs to confirm proper state transitions and telemetry behavior

Checklist:

Related Issue

N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant