Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crsf-bind button #12068

Merged
merged 4 commits into from
Nov 16, 2024
Merged

Add crsf-bind button #12068

merged 4 commits into from
Nov 16, 2024

Conversation

benjinne
Copy link
Contributor

@benjinne benjinne commented Nov 5, 2024

Adds crsf-bind button.
Based on:

image

Test Steps

The button successfully sets a CRSF (crossfire, ELRS, etc) receiver into bind mode

@HTRamsey
Copy link
Collaborator

HTRamsey commented Nov 7, 2024

Looks fine to me, do you know if there is an enum available for the rxType?

Edit: Nevermind, I saw your discussion on the other PR

@DonLakeFlyer
Copy link
Contributor

@benjinne What happens on the firmware side if you try a CSRF bind on an older firmware that doesn't support this?

@DonLakeFlyer
Copy link
Contributor

Also now that the RC_TYPE_foo enums have been added to mavlink can the code be updated to use both of those?

@benjinne
Copy link
Contributor Author

@benjinne What happens on the firmware side if you try a CSRF bind on an older firmware that doesn't support this?

I believe nothing happens. The version of ELRS supported is 3.4.0+
https://www.expresslrs.org/quick-start/binding/?h=bind#updated-binding-procedure-since-expresslrs-340

@DonLakeFlyer
Copy link
Contributor

I looked at the ArduPilot code and it's going to get confused by this. It will cause Spektrum bind to start. Are there plans to support this in ArduPilot as well? If not, then I would say this show for PX4 only.

@benjinne
Copy link
Contributor Author

Also now that the RC_TYPE_foo enums have been added to mavlink can the code be updated to use both of those?

I looked at the ArduPilot code and it's going to get confused by this. It will cause Spektrum bind to start. Are there plans to support this in ArduPilot as well? If not, then I would say this show for PX4 only.

I'll take a look. I think I can use the enum and we can update ArduPilot

@DonLakeFlyer
Copy link
Contributor

Ok, so assuming ArduPilot gets updated as well. Then I'll merge once the magic numbers are fixed.

@DonLakeFlyer
Copy link
Contributor

Fantastic, thanks

@DonLakeFlyer DonLakeFlyer merged commit 1b8f503 into mavlink:master Nov 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants