-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crsf-bind button #12068
Add crsf-bind button #12068
Conversation
Looks fine to me, do you know if there is an enum available for the rxType? Edit: Nevermind, I saw your discussion on the other PR |
@benjinne What happens on the firmware side if you try a CSRF bind on an older firmware that doesn't support this? |
Also now that the RC_TYPE_foo enums have been added to mavlink can the code be updated to use both of those? |
I believe nothing happens. The version of ELRS supported is 3.4.0+ |
I looked at the ArduPilot code and it's going to get confused by this. It will cause Spektrum bind to start. Are there plans to support this in ArduPilot as well? If not, then I would say this show for PX4 only. |
I'll take a look. I think I can use the enum and we can update ArduPilot |
Ok, so assuming ArduPilot gets updated as well. Then I'll merge once the magic numbers are fixed. |
Fantastic, thanks |
Adds crsf-bind button.
Based on:
and
Test Steps
The button successfully sets a CRSF (crossfire, ELRS, etc) receiver into bind mode