Update video fit options #12037
Merged
Update video fit options #12037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pre-existing "Stretch" option would not fill the screen as expected. The grid lines were also not accurately placed over the video for the "Stretch" option. "Stretch" is also not a great word to use because it hints the video may be transformed in a way were its aspectRatio is different from the original, which is not the case. This commit renames "Stretch" to "Fit" and fixes it so the video fills the screen when in that mode. A new mode was also added called "No Crop" which makes so the entire video is shown (no part of video goes past the bounds of the border of the screen, as would be the case in the other 3 video fit modes if the video width/height aspect ratio does not match the QGC app window width/height aspect ratio
dagar
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pre-existing video fit option "Stretch" would not fill the screen as expected. The grid lines were also not
accurately placed over the video.
"Stretch" is also not a great word to use because it hints the video may be transformed in a way were
its aspectRatio is different from the original, which is not the case.
This PR renames "Stretch" to "Fit" and fixes it so the video fills the screen when in that mode. A new mode was also added called "No Crop" which makes so the entire video is shown (no part of video goes past the bounds of the border of the screen, as would be the case in the other 3 video fit modes if the video width/height aspect ratio does not match the QGC app window width/height aspect ratio
Issue Before
Steps to reproduce
Update with this PR
follow the same steps in the "Steps to Reproduce" section, only select "Fit" (which is the new replacemnt for "Stretch")
As expected, the video now fills the screen and has the grid lines properly placed
Also notice the new mode "No Crop"
"No Crop" makes so the entire video is shown (no part of video goes past the bounds of the border of the screen, as would be the case in the other 3 video fit modes if the video width/height aspect ratio does not match the QGC app window width/height aspect ratio
ex. "No Crop" when QGC window is very wide
ex. "No Crop" when QGC window is very tall
Sponsor
This contribution was sponsored by Firestorm
