Fix issue with cached tile set download cancelation #12026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
reviewed
Oct 18, 2024
| @@ -82,11 +87,17 @@ void QGCCachedTileSet::createDownloadTask() | |||
|
|
|||
| void QGCCachedTileSet::resumeDownloadTask() | |||
| { | |||
There was a problem hiding this comment.
Should we only resume if it is already canceled? If you click Ok or Cancel the UI stops updating the download and this value can get out of sync with whether the button shows to resume/cancel
There was a problem hiding this comment.
Okay since its merged now I guess it is not necessary anymore
There was a problem hiding this comment.
I tried it out and it didn't help the problem I was noticing, so I figured just merge this and I'll look more into it later. I think it's partly on the QML side of things
There was a problem hiding this comment.
Okay got it, thanks for explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with cached tile set download cancelation
Description
Cancel download did not cancel download. It just set "downloading" flag to "false". This fix resolves this issue.
Test Steps
I have tested it locally, on release build, by starting offline map download and stopping it
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.