CMake: Find all packages in root CMakeLists.txt #11960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-cmake-packages
branch
from
3ec9ea4
to
0df31a8
Compare
msoos
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Yay, I did a full-on delete build, rebuild via cmake .. and make -j18 and this worked!! Nice. Can we please merge this? It's definitely needed for newest Arch, these dependencies have always been there, just hidden, and now cmake complains and refuses to build without explicitly naming them.
|
Pretty please let's merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently there is an occasional issue for some catching all dependencies if you don't find them all in the root cmakelists. Also, disable QtMultimedia receiver backend by default until it is stable.