Mavlink: Improve Image Transmission Protocol Handling #11845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
HTRamsey
commented
Sep 6, 2024
•
HTRamsey
commented
- Fix parenting so ImageProtocolManager is correctly destroyed
- Add starting/ending of image stream, which could be added as buttons to OpticalFlowSensor.qml
- Remove discontinued PX4Flow as it was largely an unused feature and connecting Optical Flow sensors to a GCS via serial has little real-world use. No other Optical Flow sensors have serial links
- Fix working with other sensors other than PX4Flow
- Fix working with multiple vehicles
HTRamsey
force-pushed
the
dev-mavlink-imageprotocolmanager
branch
from
c724831
to
8a84ba5
Compare
HTRamsey
force-pushed
the
dev-mavlink-imageprotocolmanager
branch
4 times, most recently
from
44e54ab
to
3dc2e41
Compare
|
How long ago did the PX4 Flow disappear? |
I believe it was discontinued quite some time ago and compatibility was removed from PX4 entirely like 3 years ago. I also saw there hasn't really been a single mention of the PX4Flow stuff in QGC anywhere online so I didn't think it was worth the extra complexity it added to the link and firmware stuff. Also forgot to mention this fixes the issue that the image handling stuff only worked with serial connected PX4Flow devices, and not with other OpticalFlow devices connected to autopilots. Also now works with multiple vehicle connections. |
|
Ok, all good then |
DonLakeFlyer
approved these changes
Sep 21, 2024
HTRamsey
force-pushed
the
dev-mavlink-imageprotocolmanager
branch
from
3dc2e41
to
371e7ff
Compare
HTRamsey
force-pushed
the
dev-mavlink-imageprotocolmanager
branch
from
371e7ff
to
c6a7a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.