Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.4] Gimbal fixes #11706

Merged
merged 5 commits into from
Aug 2, 2024
Merged

[v4.4] Gimbal fixes #11706

merged 5 commits into from
Aug 2, 2024

Commits on Jul 24, 2024

  1. Gimbal: ignore invalid gimbal_device_id

    Otherwise, we potentially work with garbage.
    julianoes committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    db54dd9 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Gimbal: Reference gimbal with manager + device IDs

    This changes how the found gimbals are referenced. Instead of only using
    the gimbal device ID for the gimbal map, we now also use the gimbal
    manager compid.
    
    This assumes that it is valid to have more than one gimbal manager with
    non-MAVLink gimbals attached, which means the gimbal_device_id would
    clash in that case, e.g. both would be 1.
    
    Therefore, we use the gimbal manager compid as well as the associated
    gimbal_device_id as the map key.
    julianoes committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    46a337a View commit details
    Browse the repository at this point in the history
  2. Gimbal: fix yaw calculation

    We should use the new yaw value, not the previous one when calculating
    the missing frame.
    julianoes committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ddeb2b5 View commit details
    Browse the repository at this point in the history
  3. Gimbal: send commands to gimbal component

    We shouldn't just send the commands to the vehicle because the gimbal
    manager might be implemented on any component, not just the autopilot.
    julianoes committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ca7a3b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Gimbal: fix operator==

    julianoes committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    cee8f6a View commit details
    Browse the repository at this point in the history