Fix colorized icon with Qt5Compat.GraphicalEffects instead MultiEffet from Qt6 #11308
Conversation
…m Qt6 At the moment, MultiEffect has limitations in its operation. It does not work with black images. Therefore, the most logical solution would be to use the features from Qt5
s-lisovenko
force-pushed
the
fix_colored_icons
branch
from
b062191 to
f9e981b
Compare
|
@HTRamsey Did you have some other way of fixing this other than reverting back? |
At the moment this is the most reliable way. Moreover, it does not depend on the Qt5Compat library. I see no reason not to continue to use it. |
|
Ah, ok. I thought this was going back to the compat thing. If it works, it works! Thanks. |
|
@DonLakeFlyer Sorry, seems like it depends on Qt5Compat. it should be presented in OS. So we need to consider to include it in cmake and qmake |
|
Ok, I'm going to revert since it will fail the AppImage I think with a missing lib. |
Yes, please. For now there no alternative in QT6. Maybe in future releases. |
|
@DonLakeFlyer could we reopen this PR and add missing Qt5Compat dependency. I think we should continue using it as non alternative in qt6. |
|
Doesn't seem like there is a way to reopen a merged PR. |
|
Ok. I will create another with missing library |
At the moment, MultiEffect has limitations in its operation. It does not work with black images. Therefore, the most logical solution would be to use the features from Qt5
https://forum.qt.io/topic/144070/qt6-color-svg-using-multieffect/8
Multieffect:
ColorOverlay:
