-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge fly view and joystick custom actions in a single backend #11207
Conversation
@nexton-winjeel FYI: As to whether to change to not allow filename setting is a problem? |
@DonLakeFlyer: It won't break anything, but it will be an annoyance. The reason we have the ability to select different files from the UI was so that we can use the one GCS setup for multiple vehicle configs, and quickly swap between custom actions if we change the active vehicle. |
Hmm, that's a reasonable use case. I'll put back the ability to switch files. |
bc8866e
to
d799372
Compare
@nexton-winjeel Can you help with testing this? |
The custom actions files are now hardwired to be loaded from the CustomActions save path location. The files uses can be set from Fly View Settings.
d799372
to
4e6be71
Compare
@DonLakeFlyer: I pulled the Linux AppImage from https://github.com/mavlink/qgroundcontrol/actions/runs/8197777789/artifacts/1308087842. Confirmed:
One thing I did note: The |
Yeah, that's slightly odd. But I wanted the files to be shareable between joystick and fly. Seems useful to just use a single file for both. |
@DonLakeFlyer thanks for this update. Just a note, I think there is a mistake in the docs/en/SUMMARY.md path, causing the docs website to break when trying to open the custom actions tab. Namely, there is an extra '(' at the link start and missing 's' in the filename before the .md extension |
@ivanzivotic Thanks for letting me know: #11246 |
Currently the Fly View and Joysticks have support for defining and executing arbitrary mavlink commands. Right now those are two different systems which work differently and use different file formats/location. This pull combines the two into a single backend which works the same way for both.
Changes:
CustomActions
directory of the normal QGC save path.FlyViewCustomActions.json
JoystickCustomActions.json
Change in function from before:
ToDo:
Related to #11205