Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base on the python version #104

Merged
merged 4 commits into from
Dec 6, 2024
Merged

base on the python version #104

merged 4 commits into from
Dec 6, 2024

Conversation

rnons
Copy link

@rnons rnons commented Dec 5, 2024

will work directly on the v2 branch after this, thanks

@rnons rnons requested a review from tulir December 5, 2024 13:03
@tulir
Copy link
Member

tulir commented Dec 5, 2024

I don't like the way protobuf embeds binary as hex in the generated go file, so I use --go_opt=embed_raw=true from https://go-review.googlesource.com/c/protobuf/+/369634 to have it in a separate binary file (see 3c9a756). In case you need to modify the protobuf schema, you can build protoc-gen-go to have that flag:

git clone --single-branch --branch v1.35.2 https://github.com/protocolbuffers/protobuf-go.git
cd protobuf-go
git fetch https://go.googlesource.com/protobuf refs/changes/34/369634/2
git cherry-pick FETCH_HEAD
go install ./cmd/protoc-gen-go/

@rnons rnons merged commit 3473f5a into v2 Dec 6, 2024
9 checks passed
@rnons rnons deleted the rnons/base branch December 6, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants