Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress: support ReadCloser #14

Merged
merged 1 commit into from
May 31, 2024
Merged

progress: support ReadCloser #14

merged 1 commit into from
May 31, 2024

Conversation

sumnerevans
Copy link
Member

Signed-off-by: Sumner Evans [email protected]

Copy link
Member

@tulir tulir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this needs to be separate? Reader could just support closing

func (r *Reader) Close() error {
  innerCloser, ok := r.inner.(io.ReadCloser)
  if ok {
    return innerCloser.Close()
  }
  return nil
}

Signed-off-by: Sumner Evans <[email protected]>
@sumnerevans sumnerevans force-pushed the progress-readcloser branch from aa79519 to 7fbbedd Compare May 30, 2024 21:36
@sumnerevans sumnerevans changed the title progress: add ReadCloser progress: support ReadCloser May 30, 2024
@sumnerevans sumnerevans merged commit 7fbbedd into main May 31, 2024
6 checks passed
@sumnerevans sumnerevans deleted the progress-readcloser branch May 31, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants