Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-compose syntax error #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dagisus
Copy link

@dagisus dagisus commented Jun 24, 2019

the docker-compose had multiple syntax and indentation errors, it was missing the version and services block and part of the mautic service parameters where indented with tabs, also the database link had an unnecessary name tag and the database host env var was referring to localhost instead of the DB service linked to it. Also there is a volume linked to a data folder that doesn't apply to most cases and is not referred to in this readme, if a "plug and play" installation is intended, is best to use the data folder in the image and explain, if data persistence is needed, then other configs must be performed.

the docker-compose had multiple syntax and indentation errors, it was missing the version and services block and part of the mautic service parameters where indented with tabs, also the database link had an unnecessary name tag and the database host env var was referring to localhost instead of the DB service linked to it. Also there is a volume linked to a data folder that doesn't apply to most cases and is not referred to in this readme, if a "plug and play" installation is intended, is best to use the data folder in the image and explain, if data persistence is needed, then other configs must be performed.
@aspiers
Copy link
Contributor

aspiers commented Jun 26, 2019

Thanks @dagisus. I already dealt with some of these issues in #111. Perhaps you could rebase yours on top of mine to avoid duplication?

mauticdb:
image: mysql:5.6
environment:
MYSQL_ROOT_PASSWORD=mysecret

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environment is an array, it must be:

- MYSQL_ROOT_PASSWORD=mysecret

@luizeof
Copy link
Member

luizeof commented Oct 15, 2019

@dagisus

Hello, how are you? sorry for the delay. Due to the moves between Mautic / Aquia there was some delay in communication between the mautic team and me about the permissions on the dockerhub and github repository.

Now the problem is solved and I will come back with the pulls and issues.

Could you please update your pull with the latest version of the master? just to avoid merge problems.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants