New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct types for JSON.stringify #190

Open

chribjel wants to merge 3 commits into mattpocock:main from chribjel:main

chribjel commented Mar 7, 2024

JSON.stringify has some caveats that is not in the standard Typescript implementation.

JSON.stringify(undefined) returns undefined, not string
JSON.stringify(function(){}) returns undefined as well.

This PR fixes that.

chribjel added 3 commits

March 7, 2024 11:51


          Add JSON.stringify entrypoint and tests

3d460f3


          Update JSON.stringify type definition to handle function types

311c3f3


          Update JSON.stringify typings to handle all functions

a9b624d

denis-sokolov commented Apr 12, 2024

Tightly related: #21, #124.

nicojs mentioned this pull request

(🎁) JSON.stringify should return string | undefined, not string #120

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet