Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objc: Make sendMode work. #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abarnert
Copy link

@abarnert abarnert commented Oct 5, 2012

  • There are a few places that use && instead of & to mask bits out
    of sendMode, which doesn't actually mask out the bits.
  • Another place is missing parens, so it ends up comparing the last
    flag instead of the masked value.
  • The net result is that changing the sendMode doesn't work in a
    variety of different cases.

- There are a few places that use `&&` instead of `&` to mask bits out
  of sendMode, which doesn't actually mask out the bits.

- Another place is missing parens, so it ends up comparing the last
  flag instead of the masked value.

- The net result is that changing the sendMode doesn't work in a
  variety of different cases.
@abarnert
Copy link
Author

abarnert commented Oct 5, 2012

I just realized that sendthreadsafe.c is copied into py-appscript and rb-appscript almost verbatim; the only changes are the filenames, the #include, and the name of the top-level function (e.g., AE_SendMessageThreadSafe vs. SendMessageThreadSafe).

And the Python and Ruby versions have the same bug, which I assume will make kAEWaitReply fail in the same way.

I'll try to find a way to test that, and then either replace this pull request with one that fixes all of the languages, or add a new one for the other languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant