Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for wide-Unicode little-endian Py3k. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for wide-Unicode little-endian Py3k. #2

wants to merge 1 commit into from

Commits on Oct 4, 2012

  1. Fix for wide-Unicode little-endian Py3k. 

    - Inside ae.c, AE_GetCFStringRef assumes that the data inside a wide
  PyUnicode is in the same endianness that CF wants. But PyUnicode is
  native-endian, kCFStringEncodingUTF32 is big-endian (if no BOM). We
  could write code to explcitly use kCFStringEncodingUTF32[LE|BE] as
  appropriate, or tack on a BOM to the start of a copy of the UTF-32
  and use kCFStringEncodingUTF32 as-is, or various other possibilities...
  but it's a lot simpler to use UTF8, and I doubt the performance will
  ever be an issue.
    @abarnert
    abarnert committed Oct 4, 2012
    Configuration menu
    Copy the full SHA
    bebe32d View commit details
    Browse the repository at this point in the history