Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed classnames not allowing / and : #474

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

petter
Copy link

@petter petter commented Feb 14, 2020

Ran into some issues where emmet wouldn't correctly expand abbreviations containing class names with a / or a :. These characters are quite commonly used in some css frameworks like TailwindCSS.

Examples:

.w-1/2

Before fix:

<div class="w-1"></div>

After fix:

<div class="w-1/2"></div>

a.hover:text-orange-300>lorem1

Before fix:

<a class="hover" href=""></a>
<text-orange-300>
    <span>Lorem</span>
</text-orange-300>

After fix:

<a class="hover:text-orange-300" href=""><span>Lorem</span></a>

@petter petter changed the title Fixed classnames allowing / and : Fixed classnames not allowing / and : Feb 14, 2020
grohiro added a commit to grohiro/emmet-vim that referenced this pull request Jul 30, 2021
Fixed classnames not allowing / and :
@joswr1ght
Copy link

Thanks for this @petter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants