Stable JSON output after replacing HashMaps with BTreeMaps #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdBook is a downstream consumer of
elasticlunr-rs
, and I submitted a patch there to enforce stable ordering of keys when it converts the search index to JSON.Another way to accomplish this is to force sorted maps in
elasticlunr
itself by using BTreeSet. (Either solution fixes the downstream issue.) I know that issue #3 says that a trie would be a better replacement though, so no worries if this is too excessive a change just for stable key ordering.