Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unnecessary /n newlines resulting in a lot of white area in the markdown #131

Closed
wants to merge 1 commit into from

Conversation

archit15singh
Copy link

@jsm28
Copy link
Contributor

jsm28 commented Jun 12, 2024

PR #120 is mainly about ensuring there are enough newlines before and after each construct (based on what newlines are required by Markdown semantics), but also avoids accumulation of duplicate newlines between adjacent constructs (while still following the design principle of keeping newlines that were present in the input HTML). It also makes sure to update all affected tests.

The removal of comments and doc strings in this PR is certainly unhelpful and inappropriate, as are the gratuitous removals of various blank lines from the source.

@archit15singh
Copy link
Author

Hi @jsm28, apologies for any confusion—my intention was to submit a draft PR, not to omit the docstrings. I plan to reinstate everything you've highlighted. After removing the newlines, the code became cluttered, so I've decided to withdraw my PR for now. Cheers! I'm sorry if my initial submission seemed unhelpful or misplaced. I'll be creating a fork to make adjustments that better suit my use case. Thanks for your feedback and for maintaining this repository; it's been immensely useful for my work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants