Subprocess shell #104
Open
Subprocess shell #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows weewx-sdr to (optionally) run the subprocess in shell mode, which is required for some mqtt command line subscription programs. This change allows weewx-sdr to process json provided by an mqtt connection. It offers a potential solution to the issue (Consume rtl_433 data via MQTT or other #100). The solution could use something like mosquitto_sub to pickup data from a running rtf_433 service. The change requires rtl_433 to provide json data on the mqtt topic.
An example config would add "use_shell = True" to the [SDR] stanza and change the cmd line to read:
cmd = "mosquitto_sub -t '<mqtt_topic>' -h <mqtt_server> -p <mqtt_port>"
A corresponding provider to the <mqtt_topic> would need to be running. A possible command line to start that could read:
rtl_433 -M utc -F "mqtt://<mqtt_server>,events=<mqtt_topic>"
This pull request corrects an issue with cleanly exiting weewx.