Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 support #93

Closed

Conversation

honzasterba
Copy link

I have taken the changes from #92 fixed up the code and added tests and CI runs for Ruby 3 and 3.1

The solution for ruby3 kwargs is to add the hash of passed kwargs in its array form the the cache ivar.

Copy link

@bkeepers bkeepers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 These changes look good to me. Hopefully it gets merged soon.

@patbl
Copy link

patbl commented Jun 5, 2022

It probably won't be merged soon: #88 (comment)

@evanbattaglia
Copy link

Thanks for doing this! Maybe we should make this against https://github.com/memoist/memoist ? Or possibly @sebjacobs would be able to approve this?

@honzasterba
Copy link
Author

@evanbattaglia moved to memoist#2

@pboling
Copy link
Contributor

pboling commented Jun 4, 2024

FYI: Added this alert to the new repo

Important

Recommendation

Consider using MemoWise instead, as it is maintained, fully tested, provides thread safety guarantees, and is much, much faster.

Other Alternatives

In case you need a tool with this feature set that is currently maintained, check out:

Tip

Seriously though, read the important note above.

Warning

If you must continue - be aware that this is unmaintained software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants