Document alternative ways of reloading #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find method_name(true) isn't very intention-revealing whereas the supported method_name(reload: true) or method_name(:reload) are much clearer alternatives and I keep having to check the source to see if it is possible, so why not document it in the README? See: https://github.com/matthewrudy/memoist/blob/d0101e8bdcb129bb4b609055db0107be2c645821/lib/memoist.rb#L52-L57
|
@olivierlacan does the The problem with this method is that it's confused by the fact it can be applied to a method with any arity. |
|
@matthewrudy It does. |
sebjacobs
force-pushed
the
master
branch
2 times, most recently
from
9d66c95
to
34f90dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find method_name(true) isn't very intention-revealing whereas the
supported method_name(reload: true) or method_name(:reload) are
much clearer alternatives and I keep having to check the source to
see if it is possible, so why not document it in the README?
See:
memoist/lib/memoist.rb
Lines 52 to 57 in d0101e8