Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR: Image link path #331

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Test PR: Image link path #331

merged 2 commits into from
Dec 20, 2023

Conversation

cwarnermm
Copy link
Member

Updated the first image on the README page to be an absolute link rather than a hashed image. Looking to verify whether GitHub converts the path to a hashed image post-commit.

Updated the first image on the README page to be an absolute link rather than a hashed image. Looking to verify whether GitHub converts the path to a hashed image post-commit.
@cwarnermm
Copy link
Member Author

Image path hasn't changed post-commit. Interested to know if merging the commit changes the path.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1005e33) 18.86% compared to head (a9ccec2) 18.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   18.86%   18.86%           
=======================================
  Files           9        9           
  Lines        1479     1479           
=======================================
  Hits          279      279           
  Misses       1149     1149           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister mickmister changed the base branch from master to master-temp December 19, 2023 23:21
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cwarnermm! I'm thinking we should chalk this up to an anomaly, and adjust each image reference to be checked in images. It's not an urgent matter. This could make for another HW opportunity when cleaning up the assets folder, or any other docs/image management needed in one of the plugin projects.

We'll keep an eye out for more references to the hashed URLs that may come up, and can address/investigate then.

Co-authored-by: Michael Kochell <[email protected]>
@cwarnermm cwarnermm merged commit d3ed94f into master-temp Dec 20, 2023
2 of 3 checks passed
@cwarnermm cwarnermm deleted the testpr-imagelinkpath branch December 20, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants