Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-820]: Added testcases for multiple server files #134

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

Added testcases for server files

  • state.go
  • user.go
  • ExecuteCommand function of command.go

@raghavaggarwal2308 raghavaggarwal2308 added the 2: Dev Review Requires review by a core committer label Oct 4, 2024
@raghavaggarwal2308 raghavaggarwal2308 marked this pull request as draft October 4, 2024 14:11
@Kshitij-Katiyar Kshitij-Katiyar changed the base branch from master to MM-768 October 7, 2024 09:56
@Kshitij-Katiyar Kshitij-Katiyar marked this pull request as ready for review October 7, 2024 09:57
server/command_test.go Outdated Show resolved Hide resolved
server/state_test.go Outdated Show resolved Hide resolved
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from MM-768 to master January 10, 2025 08:19
@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 14, 2025
@raghavaggarwal2308 raghavaggarwal2308 merged commit 72d9d94 into master Jan 14, 2025
6 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-820 branch January 14, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants