Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-507,699]: Added feature to receive notifications for different Jira actions. #1097

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
+772 −168
Open

[MM-507,699]: Added feature to receive notifications for different Jira actions. #1097

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
397bc8a
[MM-507,699]: Added feature to recieve notification for various actions
Kshitij-Katiyar Jul 3, 2024
540673b
[MM-507,699]: fixed testcases and added space in msg
Kshitij-Katiyar Jul 3, 2024
d3efc40
[MM-507,699]: fixed lint
Kshitij-Katiyar Jul 3, 2024
3298edf
Merge branch 'master' of github.com:mattermost/mattermost-plugin-jira…
Kshitij-Katiyar Jul 5, 2024
c8f5161
[MM-507,699]: Fixed failing testcases
Kshitij-Katiyar Jul 8, 2024
88c9ee6
Merge branch 'master' of github.com:mattermost/mattermost-plugin-jira…
Kshitij-Katiyar Jul 9, 2024
930fda6
Merge branch 'master' of github.com:mattermost/mattermost-plugin-jira…
raghavaggarwal2308 Jul 15, 2024
b1a320a
UI enhancements and fix responses for invalid commands
raghavaggarwal2308 Jul 15, 2024
6d89dfe
Modified the format of setting updated command response
raghavaggarwal2308 Jul 15, 2024
67e4be5
Review fix
raghavaggarwal2308 Jul 21, 2024
d79ae34
Merge branch 'master' of github.com:mattermost/mattermost-plugin-jira…
Kshitij-Katiyar Sep 18, 2024
8b38800
Merge branch 'master' of github.com:mattermost/mattermost-plugin-jira…
Kshitij-Katiyar Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
[MM-507,699]: Fixed failing testcases
@Kshitij-Katiyar
Kshitij-Katiyar committed Jul 8, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit c8f51611cbf05d24e9639bd3fb4c10285952a639
56 changes: 38 additions & 18 deletions server/command_test.go
View file
Original file line number Diff line number Diff line change
@@ -293,12 +293,12 @@ func TestPlugin_ExecuteCommand_Instance_Settings(t *testing.T) {
"no params, with notifications": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings", UserId: mockUserIDWithNotifications},
numInstances: 1,
expectedMsg: "Current settings:\n\tNotifications: on",
expectedMsg: "Current settings:\n\t- Notifications for assignee: on \n\t- Notifications for mention: on \n\t- Notifications for reporter: on \n\t- Notifications for watching: on",
},
"no params, without notifications": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings", UserId: mockUserIDWithoutNotifications},
numInstances: 1,
expectedMsg: "Current settings:\n\tNotifications: off",
expectedMsg: "Current settings:\n\t- Notifications for assignee: off \n\t- Notifications for mention: off \n\t- Notifications for reporter: off \n\t- Notifications for watching: off",
},
"unknown setting": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings" + " test", UserId: mockUserIDWithoutNotifications},
@@ -308,32 +308,52 @@ func TestPlugin_ExecuteCommand_Instance_Settings(t *testing.T) {
"set notifications without value": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings" + " notifications", UserId: mockUserIDWithoutNotifications},
numInstances: 1,
expectedMsg: "`/jira settings notifications [value]`\n* Invalid value. Accepted values are: `on` or `off`.",
expectedMsg: "`/jira settings notifications [assignee|mention|reporter|watching] [value]`\n* Invalid value. Accepted values are: `on` or `off`.",
},
"set notification with unknown value": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications test", UserId: mockUserIDWithoutNotifications},
numInstances: 1,
expectedMsg: "`/jira settings notifications [value]`\n* Invalid value. Accepted values are: `on` or `off`.",
expectedMsg: "`/jira settings notifications [assignee|mention|reporter|watching] [value]`\n* Invalid value. Accepted values are: `on` or `off`.",
},
"enable notifications": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications on", UserId: mockUserIDWithoutNotifications},
"enable assignee notifications": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications assignee on", UserId: mockUserIDWithoutNotifications},
numInstances: 1,
expectedMsg: "Settings updated. Notifications on.",
expectedMsg: "Settings updated.\n\tAssignee notifications on.",
},
"disable notifications": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications off", UserId: mockUserIDWithNotifications},
"disable assignee notifications": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications assignee off", UserId: mockUserIDWithNotifications},
numInstances: 1,
expectedMsg: "Settings updated. Notifications off.",
expectedMsg: "Settings updated.\n\tAssignee notifications off.",
},
"multiple instances are present: Notifications off": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications off --instance https://jiraurl1.com", UserId: mockUserIDWithNotifications},
numInstances: 2,
expectedMsg: "Settings updated. Notifications off.",
"enable reporter notifications": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications reporter on", UserId: mockUserIDWithoutNotifications},
numInstances: 1,
expectedMsg: "Settings updated.\n\tReporter notifications on.",
},
"multiple instances are present: Notifications on": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications on --instance https://jiraurl2.com", UserId: mockUserIDWithNotifications},
numInstances: 2,
expectedMsg: "Settings updated. Notifications on.",
"disable reporter notifications": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications reporter off", UserId: mockUserIDWithNotifications},
numInstances: 1,
expectedMsg: "Settings updated.\n\tReporter notifications off.",
},
"enable mention notifications": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications mention on", UserId: mockUserIDWithoutNotifications},
numInstances: 1,
expectedMsg: "Settings updated.\n\tMention notifications on.",
},
"disable mention notifications": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications mention off", UserId: mockUserIDWithNotifications},
numInstances: 1,
expectedMsg: "Settings updated.\n\tMention notifications off.",
},
"enable watching notifications": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications watching on", UserId: mockUserIDWithoutNotifications},
numInstances: 1,
expectedMsg: "Settings updated.\n\tWatching notifications on.",
},
"disable watching notifications": {
commandArgs: &model.CommandArgs{Command: "/jira instance settings notifications watching off", UserId: mockUserIDWithNotifications},
numInstances: 1,
expectedMsg: "Settings updated.\n\tWatching notifications off.",
},
}
for name, tt := range tests {