Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-55060 - Add PushSubTypeCalls for calls-specific push notifications #564

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Nov 14, 2023

Summary

Ticket Link

@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Nov 14, 2023
@cpoile cpoile requested a review from streamer45 November 14, 2023 18:54
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (47cd7a7) 6.10% compared to head (6cc3af7) 5.77%.

Files Patch % Lines
server/push_notifications.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #564      +/-   ##
========================================
- Coverage   6.10%   5.77%   -0.34%     
========================================
  Files         24      24              
  Lines       4602    4558      -44     
========================================
- Hits         281     263      -18     
+ Misses      4300    4277      -23     
+ Partials      21      18       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpoile
Copy link
Member Author

cpoile commented Nov 14, 2023

For more explanation, see: mattermost/mattermost#25405 (comment)

@streamer45 streamer45 added this to the v0.21.1 / MM 9.3 milestone Nov 14, 2023
Copy link
Collaborator

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we keeping NewClient out of affection? :p

@cpoile
Copy link
Member Author

cpoile commented Nov 14, 2023

so cruel :)

Copy link
Collaborator

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just wasn't meant to be :(

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 14, 2023
@cpoile
Copy link
Member Author

cpoile commented Nov 16, 2023

For the record -- we're not changing our webapp-side dependency on the MM server code, so I elected not to upgrade the mattermost-webapp dependency. I want to reduce complication and churn and only update webapp when we need to.

@cpoile cpoile merged commit 685496a into main Nov 16, 2023
4 checks passed
@cpoile cpoile deleted the MM-55060-PushSubTypeCalls branch November 16, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants