-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-55060 - Add PushSubTypeCalls for calls-specific push notifications #564
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
========================================
- Coverage 6.10% 5.77% -0.34%
========================================
Files 24 24
Lines 4602 4558 -44
========================================
- Hits 281 263 -18
+ Misses 4300 4277 -23
+ Partials 21 18 -3 ☔ View full report in Codecov by Sentry. |
For more explanation, see: mattermost/mattermost#25405 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we keeping NewClient
out of affection? :p
so cruel :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just wasn't meant to be :(
For the record -- we're not changing our webapp-side dependency on the MM server code, so I elected not to upgrade the mattermost-webapp dependency. I want to reduce complication and churn and only update webapp when we need to. |
Summary
This is the second PR to support calls-specific push notifications.
We are now sending a
sub_type
and keepingtype
asmessage
. This allows us to support old push proxies, new push proxies, old servers, new servers, and old mobile clients and new mobile clients.Previous PR: MM-55060 - Calls: Add PushTypeCalls for calls-specific push notifications #561
see also:
MM-55060 - Calls: Add PushTypeCalls for calls-specific push notifications mattermost#25405
MM-55060 - Calls: Add PushTypeCalls for calls-specific push notifications mattermost-push-proxy#110
MM-55036 - Calls: Fix: Receiving in-app notifications for calls notifications while active mattermost-mobile#7623
NOTE: will need to update the MM server dependency once that PR is merged.
Ticket Link