MM-59294: Workflow updated and release process #7
Conversation
Rajat-Dabade
added
2: Dev Review
There was a problem hiding this comment.
Thanks, @Rajat-Dabade. I've provided editorial feedback inline.
| make watch-plugin | ||
| ``` | ||
|
|
||
| ## How to Release |
There was a problem hiding this comment.
Is this necessary? @marianunez
There was a problem hiding this comment.
@esethna This was one of the suggestions from the delivery team. See this thread
There was a problem hiding this comment.
+1 - this is useful for internal documentation
|
@marianunez @cwarnermm What about the |
There was a problem hiding this comment.
@Rajat-Dabade - Please work with @marianunez on the remaining Focalboard references throughout this PR. Some may need further discussion/decision-making.
Our goal is to ensure that this repository is entirely separate from Focalboard to avoid customer confusion.
Left a comment about this section |
| To build your own version of Matterboard Boards and upload it to your own Mattermost server, follow the instructions [here](https://developers.mattermost.com/contribute/focalboard/mattermost-boards-setup-guide/). | ||
| ## Try Mattermost Boards Plugin | ||
|
|
||
| Access the latest releases of the mattermost boards plugin by downloading the `mattermost-plugin-focalboard.tar.gz` file from the releases in this repository: <https://github.com/mattermost/mattermost-plugin-boards/releases>. After downloading and installing the plugin in the System Console, select the menu in the top left corner and select **Boards**. |
There was a problem hiding this comment.
@marianunez - Does the plugin binary have "focalboard" in the name intentionally? Is there value in renaming to "boards"?
There was a problem hiding this comment.
We can rename the new bundle file but we can't rename the plugin id because of upgrades. @Rajat-Dabade please confirm the new bundle name
| Access the latest releases of the mattermost boards plugin by downloading the `mattermost-plugin-focalboard.tar.gz` file from the releases in this repository: <https://github.com/mattermost/mattermost-plugin-boards/releases>. After downloading and installing the plugin in the System Console, select the menu in the top left corner and select **Boards**. | |
| Access the latest releases of the mattermost boards plugin by downloading the `mattermost-plugin-boards.tar.gz` file from the releases in this repository: <https://github.com/mattermost/mattermost-plugin-boards/releases>. After downloading and installing the plugin in the System Console, select the menu in the top left corner and select **Boards**. |
There was a problem hiding this comment.
@marianunez Sure, When I looked into the code, I can see the id is used to generate the plugin name. Changing the Id will only affect the plugin tar file name. So if we want to change the generated tar name, then id should be changed.
There was a problem hiding this comment.
@Rajat-Dabade - Would changing id impact backwards compatibility in any way?
There was a problem hiding this comment.
@cwarnermm Yup, it will impact, if the customer has an older version plugin, then it won't be upgraded to the newer version because the comparison is done using Id.
There was a problem hiding this comment.
@Rajat-Dabade - Please review backwards compatibility requirements with @marianunez and team ahead of applying any naming changes.
There was a problem hiding this comment.
Sure. @cwarnermm, let me try it on my local and I will discuss this with @marianunez once she is back.
|
"@marianunez @cwarnermm What about the Staying informed section inside README? There are links for the focalboard public channel and we don't have a separate channel for the mattermost boards plugin. Should we create one or should it be kept as it is?" Great question, @Rajat-Dabade! I'll defer to @marianunez, but my opinion is that we create a community server boards plugin channel and invite community feedback and input there. |
Commented above that we can remove this section for now. |
marianunez
added
4: Reviews Complete
* refactor: isPlugin for API level * chore: removed GetContextConn as it is not required * chore: clean up api.go removed none required function * chore: removed commented code * refactor: removed the admin as its no log required * refactor: removed handlePostTeamRegenerateSignupToken as not used anymore * refactor: updated make file rules * refactor: removed isGuest code * refactor: removed auth login password changepassword code * chore: linter fixes * refactor: removed user login register code * chore: linter fixes * refactor: removed auth layer * refactor: removed isSingle user checks * chore: removed debugging logs * chore: removed debugging logs * revert: isGuestUser check * Deprecate standalone SQL store level (#4) * refactor: removed the mattermost auth check * refactor: removed standalone sql part of code * refactor: removed not required function from store level * refactor: removed session check for plugin * refactor: removed the unnecessary test * refactor: removed MattermostAuth * Deperate isPlugin and isSingleUser part - 2 (#5) * removed remaining singleUser and isPlugin code * chore: linter fixes * MM-59356: Fixing testcase for webapp and server (#6) * fix: webapp test cases * refactor: added rules to makefile and added github workflow for testing * chore: added ci github workflow * chore: updated github flow for ci and typos * chore: typefix * refactor: added rule to install golangci lint * chore: to trigger action * fix: error in ci.yml * refactor: updated rule * refactor: fix linter issue * [MM-59349]: Getting Rid of Mattermost Auth layer (#10) * refactor: get rid of mattermost auth layer * chore: removed removeDuplicate from isboardsFromRow * refactor: changed method to private' * refactor: private method calls private method * refactor: get license from server API * [MM-59824]: Removed website code. (#12) * MM-59294: Workflow updated and release process (#7) * refactor: updated workflow and Readme * chore: added Contributing and security.md * refactor: updated README and makefile with new release process * refactor: updated the protected branch name * refactor: readme * refactor: updated README * refactor: removed focalboard references * refactor: updated README * From `focalboard` to `board` to generate tar bundle (#14) * refactor: changed name for generating tar * refactor: changed from board to boards * refactor: changed the folder name from board to boards * fix: ci issue * chore: ci fix * chore: ci fix * minor fix
This PR include:
Stacked on: #2