MM-59579 Add tests for utils/server #8456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilander
commented
Jan 7, 2025
| await loginToServer(theme, serverUrl, displayName, configWithSingleSSO, license); | ||
|
|
||
| expect(showModal).toHaveBeenCalledWith(Screens.SSO, '', expect.any(Object), expect.any(Object)); | ||
| });*/ |
There was a problem hiding this comment.
I'm going to file a ticket to look into this one. It's a bit too dangerous of code for me to touch without the full context.
Willyfrog
approved these changes
Jan 8, 2025
pvev
reviewed
Jan 8, 2025
|
|
||
| describe('loginOptions', () => { | ||
| it('should return correct login options', () => { | ||
| const config = { |
There was a problem hiding this comment.
perhaps we should have a test helper that gives us back the base config and license objects.
There was a problem hiding this comment.
It hasn't come up too often so far when writing tests but definitely something we should consider if we find ourselves defining the config/license from scratch often
jwilander
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increase test coverage of utils/server to 90.66%.
Ticket Link
https://mattermost.atlassian.net/browse/MM-59579
Checklist
E2E iOS tests for PR.Device Information
This PR was tested on: n/a
Screenshots
n/a
Release Note