[MM-53810] Add mobile markdown support for highlighting without notifications without configuration ability #7663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-ZubairAhmed
added
2: Dev Review
M-ZubairAhmed
changed the title
larkox
requested changes
Nov 21, 2023
| export function highlightWithoutNotification(ast: Node, highlightKeys: HighlightWithoutNotificationKey[]) { | ||
| const walker = ast.walker(); | ||
|
|
||
| const patterns = highlightKeysToPatterns(highlightKeys); |
There was a problem hiding this comment.
How often is this executed? I guess only once per markdown render, but wanted to make sure. It has a couple of loops inside and wanted to make sure it is not too complex.
There was a problem hiding this comment.
as per the markdown logic this is executed on each text node of a post
Comment on lines
+12
to
+16
| SelfHostedProducts: { | ||
| STARTER: 'starter', | ||
| PROFESSIONAL: 'professional', | ||
| ENTERPRISE: 'enterprise', | ||
| }, |
There was a problem hiding this comment.
These are the same as the SKU_SHORT_NAMEs, right? Is there any strong reason not to use those?
There was a problem hiding this comment.
Although it's the same as the SKU and the same as the Licence, the key is different, so I have added it.
|
/update-branch |
M-ZubairAhmed
added
the
Build Apps for PR
mattermost-build
removed
the
Build Apps for PR
|
Building app in separate branch. |
|
/update-branch |
larkox
approved these changes
Nov 22, 2023
M-ZubairAhmed
added
Build Apps for PR
mattermost-build
removed
the
Build Apps for PR
|
Building app in separate branch. |
yasserfaraazkhan
approved these changes
Nov 23, 2023
enahum
added
4: Reviews Complete
fewva
pushed a commit
to fewva/mattermost-mobile
that referenced
this pull request
Jan 12, 2024
…ications without configuration ability (mattermost#7663)
cyrusjc
pushed a commit
to cyrusjc/mattermost-mobile
that referenced
this pull request
May 18, 2024
…ications without configuration ability (mattermost#7663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
https://mattermost.atlassian.net/browse/MM-53810
Checklist
Includes text changes and localization file updatesDevice Information
This PR was tested on:
Screenshots
Release Note