[MM-61277] Allow selecting between private and public connection types #881
+134
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agnivade @agarciamontoro Can you guys take a look at this and let me know if the approach makes sense? |
|
Self-requested a review so I don't forget! |
agnivade
reviewed
Jan 22, 2025
Comment on lines
+90
to
+93
| PrivateIP string `json:"private_ip"` | ||
| PublicIP string `json:"public_ip"` | ||
| PublicDNS string `json:"public_dns"` | ||
| PrivateDNS string `json:"private_dns"` |
There was a problem hiding this comment.
Let's make these private fields to prevent mistakes of accessing them in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
ConnectionTypedeployer configuration option to allow the user to choose between using public/private IPs and DNS. This is necessary when a load test is deployed under private subnets.Ticket Link
https://mattermost.atlassian.net/browse/MM-61277