Add new noSelectStar analyzer

main.go

@@ -16,6 +16,7 @@ import (
 	"github.com/mattermost/mattermost-govet/v2/inconsistentReceiverName"
 	"github.com/mattermost/mattermost-govet/v2/license"
 	"github.com/mattermost/mattermost-govet/v2/mutexLock"
+	"github.com/mattermost/mattermost-govet/v2/noSelectStar"
 	"github.com/mattermost/mattermost-govet/v2/openApiSync"
 	"github.com/mattermost/mattermost-govet/v2/pointerToSlice"
 	"github.com/mattermost/mattermost-govet/v2/rawSql"
@@ -47,5 +48,6 @@ func main() {
 		pointerToSlice.Analyzer,
 		mutexLock.Analyzer,
 		wraperrors.Analyzer,
+		noSelectStar.Analyzer,
 	)
 }

noSelectStar/noSelectStar.go

@@ -0,0 +1,57 @@
+package noSelectStar
+
+import (
+	"go/ast"
+	"go/token"
+	"strings"
+
+	"golang.org/x/tools/go/analysis"
+)
+
+var Analyzer = &analysis.Analyzer{
+	Name: "noSelectStar",
+	Doc:  "checks for SQL queries containing SELECT * which breaks forwards compatibility",
+	Run:  run,
+}
+
+func run(pass *analysis.Pass) (interface{}, error) {
+	inspect := func(node ast.Node) bool {
+		lit, ok := node.(*ast.BasicLit)
+		if !ok || lit.Kind != token.STRING {
+			return true
+		}
+
+		if strings.Contains(strings.ToUpper(lit.Value), "SELECT") &&
+			strings.Contains(lit.Value, "*") {
+			pass.Reportf(lit.Pos(), "do not use SELECT *: explicitly select the needed columns instead")
+		}
+		return true
+	}
+
+	inspectCalls := func(node ast.Node) bool {
+		call, ok := node.(*ast.CallExpr)
+		if !ok {
+			return true
+		}
+
+		if fun, ok := call.Fun.(*ast.Ident); ok {
+			if fun.Name == "Select" || fun.Name == "Columns" {
+				// Check all arguments for "*"
+				for _, arg := range call.Args {
+					if lit, ok := arg.(*ast.BasicLit); ok && 
+						lit.Kind == token.STRING && 
+						strings.Contains(lit.Value, "*") {
+						pass.Reportf(lit.Pos(), "do not use %s with *: explicitly select the needed columns instead", fun.Name)
+					}
+				}
+			}
+		}
+		return true
+	}
+
+	for _, f := range pass.Files {
+		ast.Inspect(f, inspect)
+		ast.Inspect(f, inspectCalls)
+	}
+	return nil, nil
+}

noSelectStar/noSelectStar_test.go

@@ -0,0 +1,13 @@
+package noSelectStar_test
+
+import (
+	"testing"
+
+	"github.com/mattermost/mattermost-govet/v2/noSelectStar"
+	"golang.org/x/tools/go/analysis/analysistest"
+)
+
+func Test(t *testing.T) {
+	testdata := analysistest.TestData()
+	analysistest.Run(t, testdata, noSelectStar.Analyzer, "a")
+}

noSelectStar/testdata/src/a/a.go

@@ -0,0 +1,37 @@
+package a
+
+func Select(args ...string)  {}
+func Columns(args ...string) {}
+
+func example() {
+	// These should trigger warnings
+	_ = "SELECT * FROM users" // want `do not use SELECT \*: explicitly select the needed columns instead`
+	_ = "select * from table" // want `do not use SELECT \*: explicitly select the needed columns instead`
+
+	// These should not trigger warnings
+	_ = "SELECT id, name FROM users"
+	_ = "Just a * by itself"
+	_ = "SELECT"
+
+	// These should trigger warnings for Select function
+	Select("*")     // want `do not use Select with \*: explicitly select the needed columns instead`
+	Select("id, *") // want `do not use Select with \*: explicitly select the needed columns instead`
+	Select("id", "*", "name") // want `do not use Select with \*: explicitly select the needed columns instead`
+	Select("id", "name", "*") // want `do not use Select with \*: explicitly select the needed columns instead`
+
+	// These should not trigger warnings for Select function
+	Select("id, name")
+	Select("")
+	Select("id", "name", "email")
+
+	// These should trigger warnings for Columns function
+	Columns("*")     // want `do not use Columns with \*: explicitly select the needed columns instead`
+	Columns("id, *") // want `do not use Columns with \*: explicitly select the needed columns instead`
+	Columns("id", "*", "name") // want `do not use Columns with \*: explicitly select the needed columns instead`
+	Columns("id", "name", "*") // want `do not use Columns with \*: explicitly select the needed columns instead`
+
+	// These should not trigger warnings for Columns function
+	Columns("id, name")
+	Columns("")
+	Columns("id", "name", "email")
+}