Some tweaks to the developer setup guide #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker issues with WSL2
|
Hello @KrisSiegel, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
|
Updated the description with another item I found and added to the PR. |
larkox
approved these changes
Apr 22, 2024
cwarnermm
approved these changes
Apr 22, 2024
cwarnermm
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After creating the issue #1353 (to which I was assigned) I went ahead and made some minor changes to the developer's setup guide. I did leave out the docker permission issue as I believe the error message may be clear enough to lead someone to resolving it relatively quickly.
I also noticed the ruby version in the mobile documentation was not inline with the requirement in the mobile repo so I updated that as well.
Ticket Link
#1353