Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGBouncer provisioning improvements #1068

Merged
merged 3 commits into from
Aug 19, 2024
Merged

PGBouncer provisioning improvements #1068

merged 3 commits into from
Aug 19, 2024

Conversation

gabrieljackson
Copy link
Contributor

This change does the following:

  • Improves handling of the PGBouncer configmap to avoid panics when it may be improperly created.
  • Run PGBouncer provisioning tasks in the external cluster type.
  • Fix a VPC ID bug for some cluster tasks.

Fixes https://mattermost.atlassian.net/browse/CLD-8137

PGBouncer provisioning improvements

This change does the following:
 - Improves handling of the PGBouncer configmap to avoid panics
   when it may be improperly created.
 - Run PGBouncer provisioning tasks in the external cluster type.
 - Fix a VPC ID bug for some cluster tasks.
@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 13, 2024
@gabrieljackson gabrieljackson marked this pull request as ready for review August 14, 2024 14:42
@gabrieljackson gabrieljackson added 2: Dev Review Requires review by a developer 2: Infra Review Requires review by a SRE labels Aug 14, 2024
Copy link
Contributor

@nickmisasi nickmisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit otherwise LGTM

internal/provisioner/external_provisioner.go Outdated Show resolved Hide resolved
@gabrieljackson gabrieljackson removed the 2: Dev Review Requires review by a developer label Aug 19, 2024
@gabrieljackson gabrieljackson merged commit bb5418b into master Aug 19, 2024
5 checks passed
@gabrieljackson gabrieljackson deleted the eks-fixes branch August 19, 2024 15:48
@gabrieljackson gabrieljackson added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Infra Review Requires review by a SRE labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants