-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added testing note #7680
base: master
Are you sure you want to change the base?
Added testing note #7680
Conversation
Newest code from mattermost has been published to preview environment for Git SHA e38d5fc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great from a technical point of view. But I'd love to get the PM point of view as well before merging, if that's possible. cc/@wiersgallak
Hey All... just reviewed the note. Good we caught that. I think we need to add something else here. When I read this:
I immediately wonder "Okay, so what should it be for those customers?" The "overspecified" case doesn't concern me really. Its the Elasticsearch underspecified. In the absence of bandwidth to gather data-driven values for these variables, can we adapt the specifications recommended for ES >=30k to something we would consider "borderline OVERspecified", then our "Important Note" would read more like:
|
@agarciamontoro - Can I get your help incorporating @sadohert's input into the note details, please? I'll ensure the note displays on applicable pages in the scale section. |
I'm onboard with Stu's idea, but coming up with such a specification without testing is... scary. Let's discuss this next week, I self-requested a review so I don't forget :) |
@cwarnermm The base branch needs to be changed to "master" before merging this. |
Started a thread to discuss with the team here: https://hub.mattermost.com/xyz/pl/wdm6e34ajtdjibd4yp6d1zixky |
Newest code from mattermost has been published to preview environment for Git SHA 223a243 |
That is perfect, @cwarnermm, thank you! I would only suggest to remove the last sentence, since we're trying to not get customers to run load-tests without an explicit approval from our side, since it can generate quite a high support load for us. And I may even remove the very first sentence as well, since the fact that we are recommending those specs is already proof that those specs "have been tested and are confirmed to support the specified number of users reliably". |
@sadohert - My latest commit incorporates @agarciamontoro's feedback and is ready for your input. Thanks! |
Newest code from mattermost has been published to preview environment for Git SHA 648c8b4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cwarnermm! I left a couple of comments below.
@@ -12,24 +12,25 @@ This page describes the Mattermost reference architecture designed for the load | |||
.. note:: | |||
- Usage of CPU, RAM, and storage space can vary significantly based on user behavior. These hardware recommendations are based on traditional deployments and may grow or shrink depending on how active your users are. | |||
- From Mattermost v10.4, Mattermost Enterprise customers can configure `Redis <https://redis.io/>`_ (Remote Dictionary Server) as an alternative cache backend. Using Redis can help ensure that Mattermost remains performant and efficient, even under heavy usage. See the :ref:`Redis cache backend <configure/environment-configuration-settings:redis cache backend>` configuration settings documentation for details. | |||
- While the following specifications may be more than sufficient for some use cases, we have not extensively tested configurations with lower resource allocations for this user scale. If cost optimization is a priority, admins may choose to experiment with smaller configurations, but we recommend starting with the tested specifications to ensure system stability and performance. Keep in mind that under-provisioning can lead to degraded user experience and additional troubleshooting effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note (and the same one in the other architectures) only applies to the Elasticsearch resource. Can we make that explicit converting this into a footnote or something similar?
+------------------------+-----------+----------------+-----------------------+ | ||
| RDS Reader | 5 | 16/128 | db.r7g.4xlarge | | ||
+------------------------+-----------+----------------+-----------------------+ | ||
| Elasticsearch Node | 2 | 4/32 | 4 x r6g.xlarge.search | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (and the other ones) should be:
| Elasticsearch Node | 2 | 4/32 | 4 x r6g.xlarge.search | | |
| Elasticsearch cluster | 4 | 8/64 | r6g.2xlarge.search | |
Co-authored-by: Alejandro García Montoro <[email protected]>
Newest code from mattermost has been published to preview environment for Git SHA 9b3977b |
@agarciamontoro - Really appreciate the technical guidance on the updates needed! Thank you! |
Newest code from mattermost has been published to preview environment for Git SHA a60d622 |
Newest code from mattermost has been published to preview environment for Git SHA ab9840d |
Newest code from mattermost has been published to preview environment for Git SHA ffe967e |
Newest code from mattermost has been published to preview environment for Git SHA 9c7c66d |
Newest code from mattermost has been published to preview environment for Git SHA 11707e7 |
Newest code from mattermost has been published to preview environment for Git SHA 62030a3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, @cwarnermm!
Newest code from mattermost has been published to preview environment for Git SHA a998186 |
Docs to-do: Add updated note to specific user count levels as needed