Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-7536: Browse channels page needs animated GIFs for mobile app workflows #7537

Merged
merged 2 commits into from
Nov 4, 2024
Merged

DOC-7536: Browse channels page needs animated GIFs for mobile app workflows #7537

merged 2 commits into from
Nov 4, 2024

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Nov 4, 2024

Summary

This PR adds visual workflows for the Mattermost mobile app tab on the Browse channels page.

Ticket Link

Fixes #7536

  • This PR follows Mattermost Contributing Guidelines.
  • The changes are tested in a local docs build.

@mattermost-build
Copy link
Contributor

Hello @Rutam21,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Nov 4, 2024

@cwarnermm Please review and suggest changes, if any. Thanks.

@lindy65 Please add this to my queue for QA Testing once the reviews are complete. Thank you.

@lindy65 lindy65 requested a review from cwarnermm November 4, 2024 10:10
@lindy65 lindy65 added the 2: Editor Review Requires review by an editor label Nov 4, 2024
@lindy65
Copy link
Contributor

lindy65 commented Nov 4, 2024

Assigned to you for testing @Rutam21 :)

@lindy65 lindy65 added the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Newest code from Rutam21 has been published to preview environment for Git SHA 69bba3b

@Rutam21
Copy link
Contributor Author

Rutam21 commented Nov 4, 2024

The changes are tested in the preview environment and reflect properly.

  • The Browse channels page now has respective workflow images under the mobile tab for visual learners.

Please refer to the screenshots below as a confirmation.

Current Docs Page [Browse channels]

Screenshot 2024-11-04 155711

Preview Environment Page Video

PR7537QATesting.mp4

[ Awaiting final review from @cwarnermm ]

cc: @lindy65

@lindy65
Copy link
Contributor

lindy65 commented Nov 4, 2024

Thanks so much for testing @Rutam21 :)

cwarnermm
cwarnermm approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Rutam21!

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request QA-done QA review is complete and removed 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 4, 2024
@cwarnermm cwarnermm merged commit a9ac45f into mattermost:master Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor QA-done QA review is complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browse channels page needs animated GIFs for mobile app workflows
4 participants
@Rutam21 @mattermost-build @lindy65 @cwarnermm